perf: presize node-set maps in mapNodes, ClosestNodes and winnowNodes#563
Merged
Conversation
Three internal helpers build a map[*html.Node]bool from a known set of nodes (or use one as a dedup accumulator over a known number of input nodes) but allocate the map without a size hint. They then incur grow-and-double rehashing as entries are inserted. Pass len(nodes) as the size hint at make time: - traversal.go mapNodes: dedup map shared by appendWithoutDuplicates across every per-node result. mapNodes is the engine behind most traversal helpers (Parents, Children, Next/Prev, Siblings, Find*, Contents, ...), so the impact is broad. - traversal.go ClosestNodes: target-node set built from nodes... - filter.go winnowNodes: large-N path's lookup set built from nodes... Double-digit performance gains across ~all benchmarks.
Member
|
Thanks for the batch of PRs, love those small, focused improvements! Let me know if you have more coming in, once you're done with them I'll cut a new release. |
Contributor
Author
|
Thank you for your patience reviewing my late-night profiler-infused pull-requests :) I'll keep sending them until there are no more low-hanging fruits, so likely at least until the end of next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three internal helpers build a map[*html.Node]bool from a known set of nodes (or use one as a dedup accumulator over a known number of input nodes) but allocate the map without a size hint. They then incur grow-and-double rehashing as entries are inserted.
Pass len(nodes) as the size hint at make time:
Double-digit performance gains across ~all benchmarks.